Metric Export to return dedicated ExportResult #2600
Conversation
|
@scottgerring @lalitb My attempt at Export error for Metrics. To ease merge conflicts, maybe we should get just the Enum/Result alone in a small PR and get it merged, so we can work without conflicts. |
| #[derive(Error, Debug)] | ||
| /// Errors that can occur during export. | ||
| /// TODO: This should be ExportError, but that can be done after rest of repo changes are done. | ||
| pub enum ExportErrorMetric { |
There was a problem hiding this comment.
After checking more, this enum would also need AlreadyShutDown variant. Which means we should be able to re-use the same enum for Export,Shutdown,ForceFlush.
@scottgerring @lalitb Let me know if you agree. I'll make a small PR, just adding the common enum first, and then divide&conquer using it in all places.
There was a problem hiding this comment.
I'll make a small PR, just adding the common enum first, and then divide&conquer using it in all places.
Looks good to me.
|
Closing in favor of #2604 |
2 participants
Continuing this https://github.com/open-telemetry/opentelemetry-rust/pull/2573/files for ExportResult. Only touching Metrics, but this should be reused for all signals.